KurtYoung commented on a change in pull request #9952:
[FLINK-14321][sql-parser] Support to parse watermark statement in SQL DDL
URL: https://github.com/apache/flink/pull/9952#discussion_r338412389
##########
File path:
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl
##########
@@ -27,9 +27,31 @@ void TableColumn(TableCreationContext context) :
UniqueKey(context.uniqueKeysList)
|
ComputedColumn(context)
+ |
+ Watermark(context)
)
}
+void Watermark(TableCreationContext context) :
+{
+ SqlIdentifier columnName;
+ SqlParserPos pos;
+ SqlNode watermarkStrategy;
+}
+{
+ <WATERMARK> {pos = getPos();} <FOR>
+ columnName = CompoundIdentifier()
+ <AS>
+ watermarkStrategy = Expression(ExprContext.ACCEPT_NON_QUERY) {
+ if (context.watermark != null) {
+ throw SqlUtil.newContextException(pos,
+ ParserResource.RESOURCE.multipleWatermarksUnsupported());
Review comment:
Why not using normal Exception here? It looks really complex(by introducing
new a Resource concept) to just throw an exception..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
