JingsongLi commented on issue #9909: [FLINK-14381][table] Partition field names 
should be got from CatalogTable instead of source/sink
URL: https://github.com/apache/flink/pull/9909#issuecomment-545792835
 
 
   > For `LogicalSink`, my feeling is we should provide enough information such 
as partition keys at first step instead of looking to catalog manager during 
conversion. Have you considered about this approach?
   
   But consider the future needs, we need get some other informations from 
catalog table or catalog, we don't need to pass all informations to 
`LogicalSink`, for example, we need do the partition pruning from catalog, it 
is better to just pass an identifier.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to