dawidwys commented on a change in pull request #9937: [FLINK-14416][table] Add
Module interface and ModuleManager
URL: https://github.com/apache/flink/pull/9937#discussion_r338446056
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/java/internal/StreamTableEnvironmentImpl.java
##########
@@ -104,7 +106,9 @@ public static StreamTableEnvironment create(
settings.getBuiltInCatalogName(),
new
GenericInMemoryCatalog(settings.getBuiltInCatalogName(),
settings.getBuiltInDatabaseName()));
- FunctionCatalog functionCatalog = new
FunctionCatalog(catalogManager);
+ ModuleManager moduleManager = new ModuleManager();
+
+ FunctionCatalog functionCatalog = new
FunctionCatalog(catalogManager, moduleManager);
Review comment:
Comment to the original comment.
Yes this is a repeated pattern, because this is the good coding guideline
approved by the Flink community:
https://flink.apache.org/contributing/code-style-and-quality-common.html#design-for-testability.
Creating objects within constructors is an anti-pattern that the Flink
community highly discourages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
