KurtYoung commented on a change in pull request #9966: [FLINK-14053]
[blink-planner] DenseRankAggFunction.accumulateExpressions. it should be thinki…
URL: https://github.com/apache/flink/pull/9966#discussion_r338481514
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/OverWindowITCase.scala
##########
@@ -386,6 +386,28 @@ class OverWindowITCase extends BatchTestBase {
row(5, 5)
)
)
+
+ // deal with input with 0 as the first row's rank field
+ checkResult(
+ "SELECT f, dense_rank() over (order by d) FROM Table5",
Review comment:
If I don't misunderstood anything, your test seems to be wrong.
The data of column d is `1, 2, 2, 3, 3, 3, 4, 4, 4, 4, 5, 5, 5, 5, 5`, how
could it possible that the `dense_rank` on column d becomes `1, 2, 3, ..., 14,
15`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
