KurtYoung commented on issue #9909: [FLINK-14381][table] Partition field names should be got from CatalogTable instead of source/sink URL: https://github.com/apache/flink/pull/9909#issuecomment-545841476 You mean catalog table, not catalog manager, right? > > 3 minor reasons, none of them are critical but kind of bothers me: > > > > 1. Accessing catalog manager may introduce external system access and could cost some time which will increase the optimization duration. > > 2. Access catalog manager multiple times could cause data inconsistency. We already get such information before entering to optimization phase, and information might changed when you look up the catalog manager again. > > 3. As pointed out in #2, we already get all the information you needed before optimization, why bother to get it again? > > Thanks @KurtYoung to explain it. none of them are critical but can convince me, I'll update it. But I think I can keep the pass of identifier and catalog manager, what do you think? You mean catalog table, not catalog manager, right?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
