wuchong commented on a change in pull request #9909: [FLINK-14381][table]
Partition field names should be got from CatalogTable instead of source/sink
URL: https://github.com/apache/flink/pull/9909#discussion_r338531342
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/catalog/DatabaseCalciteSchema.java
##########
@@ -143,7 +143,8 @@ private Table convertConnectorTable(
return new TableSourceTable<>(
tableSource,
isStreamingMode,
-
FlinkStatistic.builder().tableStats(tableStats).build());
+
FlinkStatistic.builder().tableStats(tableStats).build(),
+ null);
Review comment:
Actually, I have some concern to put the whole `CatalogTable` in
`TableSourceTable`. Because in CatalogTable, it may contains all the computed
columns defined in DDL. But not all of them are retained in source, some of
them may be applied to the following `LogicalProject`. Could we only put the
information we need in `TabeSourceTable` and `TableSinkTable`? e.g.
`List<String> partitionKeys`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
