JingsongLi commented on a change in pull request #9909: [FLINK-14381][table]
Partition field names should be got from CatalogTable instead of source/sink
URL: https://github.com/apache/flink/pull/9909#discussion_r338899223
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/catalog/DatabaseCalciteSchema.java
##########
@@ -143,7 +143,8 @@ private Table convertConnectorTable(
return new TableSourceTable<>(
tableSource,
isStreamingMode,
-
FlinkStatistic.builder().tableStats(tableStats).build());
+
FlinkStatistic.builder().tableStats(tableStats).build(),
+ null);
Review comment:
Hi Jark, I don't quite understand the expression in this source, but I think
we need a good name to clarify it. It's may not just the `TableSourceTable`
that saves them together? I think they are all attributes of table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
