[
https://issues.apache.org/jira/browse/FLINK-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963285#comment-14963285
]
ASF GitHub Bot commented on FLINK-2857:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1263#issuecomment-149210731
Looks good to me. Will fix the typo and merge this PR.
> Gelly API improvements
> ----------------------
>
> Key: FLINK-2857
> URL: https://issues.apache.org/jira/browse/FLINK-2857
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
> Reporter: Vasia Kalavri
> Assignee: Vasia Kalavri
>
> During the Flink Forward Gelly School training, I got some really valuable
> feedback from participants on what they found hard to grasp or non-intuitive
> in the API.
> Based on that, I propose we make the following improvements:
> - rename the mapper in creation methods to {{VertexInitializer}}, so that
> its purpose is easier to understand.
> - add a {{fromTuple2DataSet}} method to easily create graphs from {{Tuple2}}
> datasets, i.e. edges with no values.
> - in {{joinWith*}} methods, it is hard to understand what are the parameters
> in the mapper and what will be the output. I suggest we flatten them, try to
> give intuitive names and improve the javadocs.
> - in neighborhood methods, it is hard to understand what are the arguments of
> the {{EdgeFunction.iterateEdges}} and {{ReduceEdgesFunction.reduceEdges}}.
> Javadocs and parameter names could be improved here too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
