sunhaibotb commented on a change in pull request #9854: [FLINK-14230][task] 
Change the endInput call of the downstream operator to after the upstream 
operator closes
URL: https://github.com/apache/flink/pull/9854#discussion_r339010844
 
 

 ##########
 File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTaskTest.java
 ##########
 @@ -479,5 +481,40 @@ public void cancel() {
                        running = false;
                }
        }
+
+       private static final class OutputRecordInCloseTestSource extends 
RichSourceFunction<String> {
+
+               private final String name;
+               private final String[] elements;
+
+               private transient volatile boolean canceled = false;
+
+               private transient SourceContext<String> context;
 
 Review comment:
   We need to use `context` to output data in `close`, but `canceled` can be 
removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to