lirui-apache commented on a change in pull request #9979: [FLINK-14417][table]
Develop CoreModule to provide Flink built-in functions
URL: https://github.com/apache/flink/pull/9979#discussion_r339016189
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/module/ModuleManager.java
##########
@@ -109,7 +109,7 @@ public void unloadModule(String name) throws
ModuleNotFoundException {
*/
public Optional<FunctionDefinition> getFunctionDefinition(String name) {
Optional<Module> module = modules.values().stream()
- .filter(p -> p.listFunctions().stream().anyMatch(e ->
e.equals(name)))
+ .filter(p -> p.listFunctions().stream().anyMatch(e ->
e.equalsIgnoreCase(name)))
Review comment:
Maybe it's better to normalize `e` and `name` and just call `e.equals(name)`?
Btw, how to handle the case if some modules are case sensitive and some are
not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
