bowenli86 commented on a change in pull request #9971: [FLINK-14490][table] Add
methods for interacting with temporary objects
URL: https://github.com/apache/flink/pull/9971#discussion_r339233457
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/java/BatchTableEnvironment.java
##########
@@ -109,24 +109,50 @@
<T> Table fromDataSet(DataSet<T> dataSet, String fields);
/**
- * Registers the given {@link DataSet} as table in the
- * {@link TableEnvironment}'s catalog.
- * Registered tables can be referenced in SQL queries.
+ * Creates a view from the given {@link DataSet}.
+ * Registered views can be referenced in SQL queries.
*
- * The field names of the {@link Table} are automatically derived from
the type of the{@link DataSet}.
+ * <p>The field names of the {@link Table} are automatically derived
+ * from the type of the {@link DataSet}.
+ *
+ * <p>The view is registered in the current catalog and database. To
register the view in
Review comment:
this comment can be a bit misleading as the view is registered actually only
in the namespace of current catalog and db, but isn't physically located in the
catalog/db, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
