[
https://issues.apache.org/jira/browse/FLINK-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964046#comment-14964046
]
ASF GitHub Bot commented on FLINK-2853:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1267#discussion_r42425336
--- Diff: pom.xml ---
@@ -163,6 +163,16 @@ under the License.
<type>jar</type>
<scope>test</scope>
</dependency>
+ <dependency>
--- End diff --
I don't think it is necessary to add these dependency to the root pom. We
added a dedicated Maven module for micro benchmarks (`flink-benchmark`). This
is where the code and the dependencies should go, IMO.
> Apply JMH on MutableHashTablePerformanceBenchmark class.
> --------------------------------------------------------
>
> Key: FLINK-2853
> URL: https://issues.apache.org/jira/browse/FLINK-2853
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Reporter: GaoLun
> Assignee: GaoLun
> Priority: Minor
> Labels: easyfix
>
> JMH is a Java harness for building, running, and analysing
> nano/micro/milli/macro benchmarks.Use JMH to replace the old micro benchmarks
> method in order to get much more accurate results.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
