gyfora commented on a change in pull request #10010: [FLINK-10435][yarn]Client 
sporadically hangs after Ctrl + C
URL: https://github.com/apache/flink/pull/10010#discussion_r339429351
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
 ##########
 @@ -1241,7 +1241,6 @@ private void failSessionDuringDeployment(YarnClient 
yarnClient, YarnClientApplic
                        // call (we don't know if the application has been 
deployed when the error occured).
                        LOG.debug("Error while killing YARN application", e);
                }
-               yarnClient.stop();
 
 Review comment:
   Why did we remove this? Seems like an unrelated change compared to having a 
new client in the DeploymentFailureHook

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to