kl0u commented on a change in pull request #9976: [FLINK-14493][core] Introduce 
data types to ConfigOptions.
URL: https://github.com/apache/flink/pull/9976#discussion_r339461822
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java
 ##########
 @@ -349,13 +345,11 @@ public void setLong(ConfigOption<Long> key, long value) {
         *        the default value which is returned in case there is no value 
associated with the given key
         * @return the (default) value associated with the given key
         */
+       @Deprecated
 
 Review comment:
   I think it would be nicer if for the `@Deprecated` methods, you added the 
`"@deprecated use the X.Y instead".` to javadoc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to