TisonKun commented on a change in pull request #9974:
[FLINK-14501][FLINK-14502] Decouple ClusterDescriptor/ClusterSpecification from
CommandLine
URL: https://github.com/apache/flink/pull/9974#discussion_r339674656
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendRunTest.java
##########
@@ -145,12 +147,23 @@ public void testParallelismWithOverflow() throws
Exception {
//
--------------------------------------------------------------------------------------------
public static void verifyCliFrontend(
- AbstractCustomCommandLine<?> cli,
+ AbstractCustomCommandLine cli,
String[] parameters,
int expectedParallelism,
boolean isDetached) throws Exception {
RunTestingCliFrontend testFrontend =
- new RunTestingCliFrontend(cli, expectedParallelism,
isDetached);
+ new RunTestingCliFrontend(new
DefaultClusterClientServiceLoader(), cli, expectedParallelism, isDetached);
+ testFrontend.run(parameters); // verifies the expected values
(see below)
+ }
+
+ public static void verifyCliFrontend(
Review comment:
This utility is only used in `CliFrontendRunWithYarnTest`. Please move there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
