wuchong commented on a change in pull request #10000: [FLINK-14398][SQL/Legacy
Planner]Further split input unboxing code into separate methods
URL: https://github.com/apache/flink/pull/10000#discussion_r339910726
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/codegen/MatchCodeGenerator.scala
##########
@@ -574,13 +584,14 @@ class MatchCodeGenerator(
private def generateMeasurePatternVariableExp(patternName: String):
GeneratedPatternList = {
val listName = newName("patternEvents")
+ reusableMemberStatements.add(s"java.util.List $listName = new
java.util.ArrayList();")
val code = if (patternName == ALL_PATTERN_VARIABLE) {
addReusablePatternNames()
val patternTerm = newName("pattern")
j"""
- |java.util.List $listName = new java.util.ArrayList();
+ |$listName.clear();
Review comment:
Do we have tests to cover this change?
I would prefer `$listName = new java.util.ArrayList();`, because
`$listName.clear();` will reuse the output object and may cause some unexpected
problems (maybe `$listName` will be buffered in downstream).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
