JingsongLi commented on a change in pull request #10027: [FLINK-14549][Table
SQL/Planner] Bring more detail by using logicalTy…
URL: https://github.com/apache/flink/pull/10027#discussion_r339976686
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/sinks/TableSinkUtils.scala
##########
@@ -61,10 +61,10 @@ object TableSinkUtils {
// format table and table sink schema strings
val srcSchema = srcFieldNames.zip(srcFieldTypes)
- .map { case (n, t) => s"$n: ${t.getConversionClass.getSimpleName}" }
+ .map { case (n, t) => s"$n: ${fromDataTypeToLogicalType(t).toString}" }
Review comment:
Can you create a `srcLogicalTypes` and `sinkLogicalTypes`?
With these two field, should be easier to debug and reduce code duplicate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
