azagrebin opened a new pull request #10034: [FLINK-14400] Shrink scope of MemoryManager from TaskExecutor to slot URL: https://github.com/apache/flink/pull/10034 ## What is the purpose of the change `MemoryManager` currently manages the memory bookkeeping for all slots/tasks inside one `TaskExecutor`. For better abstraction and isolation of slots, we can shrink its scope and make it per slot. The memory limits are fixed now per slot at the moment of slot creation. All operators, sharing the slot, will get their fixed fractional limits. In future, we might make it possible for operators to over-allocate beyond their fraction limit if there is some available free memory in the slot but it should be possible to reclaim the over-allocated memory at any time if other operator decides to claim its fair share within its limit. ## Brief change log - introduce `TaskSlotTableBuilder` for tests - Refactor out slots creation from the `TaskSlotTable` constructor to the factory method in `TaskManagerServices` - `TaskSlot` has its own memory manager and `close` method to shutdown the memory manager and release all left unreleased memory (with a warning check whether everything has been already released) - When the `TaskSlotTable` is stopped, all slots are closed as well. Currently, it basically happens only if the TM is completely stoped, same as for the former TM's global memory manager - Remove the global memory manager from `TaskManagerServices`, keep only memory size - Remove now redundant number of slots from the `MemoryManager`. ## Verifying this change Existing unit tests. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
