bowenli86 commented on a change in pull request #9988: [FLINK-14418][hive] 
Create HiveModule to provide Hive built-in functions
URL: https://github.com/apache/flink/pull/9988#discussion_r340315608
 
 

 ##########
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/factories/HiveFunctionDefinitionFactory.java
 ##########
 @@ -67,14 +69,26 @@ public HiveFunctionDefinitionFactory(HiveConf hiveConf) {
                this.hiveShim = HiveShimLoader.loadHiveShim(hiveVersion);
        }
 
+       public HiveFunctionDefinitionFactory(String hiveVersion) {
 
 Review comment:
   what do you mean? can you elaborate?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to