wuchong commented on a change in pull request #10013:
[FLINK-13869][table-planner-blink][hive] Hive functions can not work in blink
planner stream mode
URL: https://github.com/apache/flink/pull/10013#discussion_r340449692
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/AggregateUtil.scala
##########
@@ -747,7 +747,7 @@ object AggregateUtil extends Enumeration {
private[flink] def isTableAggregate(aggCalls: util.List[AggregateCall]):
Boolean = {
aggCalls
.filter(e => e.getAggregation.isInstanceOf[AggSqlFunction])
- .map(e =>
e.getAggregation.asInstanceOf[AggSqlFunction].makeFunction(null, null))
+ .map(e =>
e.getAggregation.asInstanceOf[AggSqlFunction].aggregateFunction)
Review comment:
Thanks. I got the reason. Could you add a javadoc for `makeFunction` that it
is only used for Hive UDF support, this is a temporary solusion and should be
removed once FLIP-65 is finished.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
