KurtYoung commented on a change in pull request #9796:
[FLINK-14253][table-planner-blink] Add hash distribution and sort grouping only
when dynamic partition insert
URL: https://github.com/apache/flink/pull/9796#discussion_r340466765
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/delegation/PlannerBase.scala
##########
@@ -188,7 +183,12 @@ abstract class PlannerBase(
s"${classOf[OverwritableTableSink].getSimpleName} but actually
got " +
sink.getClass.getName)
}
- LogicalSink.create(input, sink, identifier.toString, table)
+ LogicalSink.create(
+ input,
+ sink,
+ identifier.toString,
+ table,
+ catalogSink.getStaticPartitions.toMap)
Review comment:
why toMap here? `catalogSink.getStaticPartitions` is already a Map
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
