JingsongLi commented on a change in pull request #9796:
[FLINK-14253][table-planner-blink] Add hash distribution and sort grouping only
when dynamic partition insert
URL: https://github.com/apache/flink/pull/9796#discussion_r340467626
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/delegation/PlannerBase.scala
##########
@@ -188,7 +183,12 @@ abstract class PlannerBase(
s"${classOf[OverwritableTableSink].getSimpleName} but actually
got " +
sink.getClass.getName)
}
- LogicalSink.create(input, sink, identifier.toString, table)
+ LogicalSink.create(
+ input,
+ sink,
+ identifier.toString,
+ table,
+ catalogSink.getStaticPartitions.toMap)
Review comment:
The default corresponding class is `mutable.Map` in Scala for
`java.util.Map` in Java.
But the default `Map` in Scala is immutable map. We should use immutable map
too. So need `toMap` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
