xuyang1706 commented on issue #9082: [FLINK-13207][ml] Add the algorithm of 
Fast Fourier Transformation(FFT)
URL: https://github.com/apache/flink/pull/9082#issuecomment-547788706
 
 
   > Thanks for the contribution @xuyang1706 . I left a few comments with more 
higher level questions.
   > Regarding the placement. I think this should be considered as a transform 
since FFT is a transform itself. even if `DCT` is another transform that 
utilizes this algorithm. what do you think?
   
   Thanks for your advices @walterddr . I have refined the code. Yes, there is 
DCT-Transformer using this FFT class. For the FFT transform real number to 
complex number, but the common ML algorithms are dealing with real number only, 
we have no plan to submit FFT-Transformer recently.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to