azagrebin commented on a change in pull request #9996:
[FLINK-14532][coordination] Split PartitionTracker
URL: https://github.com/apache/flink/pull/9996#discussion_r340512777
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/JobMasterPartitionTrackerImpl.java
##########
@@ -98,53 +82,22 @@ public void
stopTrackingAndReleasePartitions(Collection<ResultPartitionID> resul
.filter(Optional::isPresent)
.map(Optional::get)
.collect(Collectors.groupingBy(
- partitionMetaData ->
partitionMetaData.producingTaskExecutorResourceId,
+ PartitionTrackerEntry::getKey,
Collectors.mapping(
- partitionMetaData ->
partitionMetaData.resultPartitionDeploymentDescriptor,
+ PartitionTrackerEntry::getMetaInfo,
toList())));
partitionsToReleaseByResourceId.forEach(this::internalReleasePartitions);
}
- @Override
- public void stopTrackingPartitions(Collection<ResultPartitionID>
resultPartitionIds) {
- Preconditions.checkNotNull(resultPartitionIds);
-
- resultPartitionIds.forEach(this::internalStopTrackingPartition);
- }
-
@Override
public void stopTrackingAndReleasePartitionsFor(ResourceID
producingTaskExecutorId) {
Preconditions.checkNotNull(producingTaskExecutorId);
- // this is a bit icky since we make 2 calls to
pT#stopTrackingPartitions
- Collection<ResultPartitionID> resultPartitionIds =
partitionTable.stopTrackingPartitions(producingTaskExecutorId);
-
- stopTrackingAndReleasePartitions(resultPartitionIds);
- }
-
- @Override
- public boolean isTrackingPartitionsFor(ResourceID
producingTaskExecutorId) {
- Preconditions.checkNotNull(producingTaskExecutorId);
-
- return
partitionTable.hasTrackedPartitions(producingTaskExecutorId);
- }
-
- @Override
- public boolean isPartitionTracked(final ResultPartitionID
resultPartitionID) {
- Preconditions.checkNotNull(resultPartitionID);
+ Collection<ResultPartitionDeploymentDescriptor>
resultPartitionIds = stopTrackingPartitionsFor(producingTaskExecutorId)
+
.stream().map(PartitionTrackerEntry::getMetaInfo).collect(toList());
Review comment:
style nit: break the whole chain
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
