zentol commented on a change in pull request #9797: [FLINK-14059][core]
Introduce option allVerticesInSameSlotSharingGroupByDefault in ExecutionConfig
URL: https://github.com/apache/flink/pull/9797#discussion_r340554804
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/utils/BatchTestBase.scala
##########
@@ -479,6 +479,6 @@ object BatchTestBase {
conf.getConfiguration.setString(TABLE_EXEC_RESOURCE_HASH_JOIN_MEMORY,
"2mb")
conf.getConfiguration.setString(TABLE_EXEC_RESOURCE_SORT_MEMORY, "1mb")
conf.getConfiguration.setString(TABLE_EXEC_RESOURCE_EXTERNAL_BUFFER_MEMORY,
"1mb")
- conf.getConfiguration.setString(TABLE_EXEC_SHUFFLE_MODE,
ShuffleMode.PIPELINED.toString)
+ conf.getConfiguration.setString(TABLE_EXEC_SHUFFLE_MODE,
ShuffleMode.BATCH.toString)
Review comment:
The commits in this PR alone don't cause the deadlock, correct? If so, then
this change should be moved to the PR which modifies the actual runtime logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
