liupc commented on a change in pull request #9703: [FLINK-14038]Add default GC
options for flink on yarn to facilitate debugging
URL: https://github.com/apache/flink/pull/9703#discussion_r340611921
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
##########
@@ -397,7 +398,12 @@ public static String getTaskManagerShellCommand(
startCommandValues.put("jvmmem", StringUtils.join(params, ' '));
- String javaOpts =
flinkConfig.getString(CoreOptions.FLINK_JVM_OPTIONS);
+ String javaOpts = "";
+ // Add default gc logging options if enabled
+ javaOpts += getGCLoggingOpts(logDirectory, flinkConfig);
+ // Add default heap dump options if enabled
+ javaOpts += " " + getHeapdumpOpts(appId, "taskmanager",
logDirectory, flinkConfig);
Review comment:
Thank you for point it out! I will update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
