azagrebin commented on a change in pull request #8194:
[FLINK-12216][Runtime]Respect the number of bytes from input parameters in
HybridMemorySegment
URL: https://github.com/apache/flink/pull/8194#discussion_r341009633
##########
File path:
flink-core/src/test/java/org/apache/flink/core/memory/MemorySegmentTestBase.java
##########
@@ -1955,11 +1955,6 @@ private void testByteBufferGet(boolean directBuffer) {
assertArrayEquals(bytes, result);
}
- @Test(expected = ReadOnlyBufferException.class)
- public void testHeapByteBufferGetReadOnly() {
Review comment:
Does the exception type not depend on the type of target buffer (input arg)?
It looks like it is the same `IllegalArgumentException` for both test
subclasses, also in the PR.
Would it not be sufficient just to change `ReadOnlyBufferException` to
`IllegalArgumentException` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
