dawidwys commented on a change in pull request #10059: [FLINK-14543][table]
Support partition for temporary table
URL: https://github.com/apache/flink/pull/10059#discussion_r341128392
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/descriptors/ConnectTableDescriptor.java
##########
@@ -136,14 +137,24 @@ public void createTemporaryTable(String path) {
" use
registerTableSource/registerTableSink/registerTableSourceAndSink.");
Review comment:
That's what we are doing. The `schemaDescriptor` contain those properties.
Previously I think it was possible that the {{TableSource}} produced the
{{TableSchema}} itself without getting any schema from properties. We cannot
support this scenario anymore. Though I think all the connectors we provide so
far require the schema properties anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
