zhuzhurk commented on a change in pull request #10006: [FLINK-14312][runtime] Support building logical pipelined regions from JobGraph URL: https://github.com/apache/flink/pull/10006#discussion_r341192663
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/topology/DefaultLogicalTopology.java ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.jobgraph.topology; + +import org.apache.flink.runtime.executiongraph.failover.flip1.PipelinedRegionComputeUtil; +import org.apache.flink.runtime.jobgraph.IntermediateDataSet; +import org.apache.flink.runtime.jobgraph.IntermediateDataSetID; +import org.apache.flink.runtime.jobgraph.JobGraph; +import org.apache.flink.runtime.jobgraph.JobVertex; +import org.apache.flink.runtime.jobgraph.JobVertexID; +import org.apache.flink.util.IterableUtils; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.Optional; +import java.util.Set; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * Default implementation of {@link LogicalTopology}. + * It is an adapter of {@link JobGraph}. + */ +public class DefaultLogicalTopology implements LogicalTopology<DefaultLogicalVertex, DefaultLogicalResult> { + + private final boolean containsCoLocationConstraints; + + private final List<DefaultLogicalVertex> verticesSorted; + + private final Map<JobVertexID, DefaultLogicalVertex> idToVertexMap; + + private final Map<IntermediateDataSetID, DefaultLogicalResult> idToResultMap; + + private transient Set<LogicalPipelinedRegion> regions; + + public DefaultLogicalTopology(final JobGraph jobGraph) { + checkNotNull(jobGraph); + + this.containsCoLocationConstraints = IterableUtils.toStream(jobGraph.getVertices()) + .map(JobVertex::getCoLocationGroup) + .anyMatch(Objects::nonNull); + + this.verticesSorted = new ArrayList<>(jobGraph.getNumberOfVertices()); + this.idToVertexMap = new HashMap<>(); + this.idToResultMap = new HashMap<>(); + + buildVerticesAndResults(jobGraph); + } + + private void buildVerticesAndResults(final JobGraph jobGraph) { + for (JobVertex jobVertex : jobGraph.getVerticesSortedTopologicallyFromSources()) { + + final DefaultLogicalVertex logicalVertex = new DefaultLogicalVertex(jobVertex, this::getResult); + this.verticesSorted.add(logicalVertex); + this.idToVertexMap.put(logicalVertex.getId(), logicalVertex); + + for (IntermediateDataSet intermediateDataSet : jobVertex.getProducedDataSets()) { + DefaultLogicalResult logicalResult = new DefaultLogicalResult(intermediateDataSet, this::getVertex); + idToResultMap.put(logicalResult.getId(), logicalResult); + } + } + } + + @Override + public Iterable<DefaultLogicalVertex> getVertices() { + return verticesSorted; + } + + @Override + public boolean containsCoLocationConstraints() { + return containsCoLocationConstraints; + } + + private DefaultLogicalVertex getVertex(final JobVertexID vertexId) { + return Optional.ofNullable(idToVertexMap.get(vertexId)) + .orElseThrow(() -> new IllegalArgumentException("can not find vertex: " + vertexId)); + } + + private DefaultLogicalResult getResult(final IntermediateDataSetID resultId) { + return Optional.ofNullable(idToResultMap.get(resultId)) + .orElseThrow(() -> new IllegalArgumentException("can not find result: " + resultId)); + } + + public Set<LogicalPipelinedRegion> getLogicalPipelinedRegions() { + if (regions == null) { + regions = buildLogicalPipelinedRegions(); + } + return regions; + } Review comment: done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
