xuefuz commented on a change in pull request #10062: [FLINK-14588][hive]
Support Hive version 1.0.0 and 1.0.1
URL: https://github.com/apache/flink/pull/10062#discussion_r341267672
##########
File path: flink-connectors/flink-connector-hive/pom.xml
##########
@@ -666,7 +666,23 @@ under the License.
</build>
<profiles>
- <!-- Activate this profile with -Phive-1.2.1 to build and test
against hive-1.2.1 -->
+ <!-- Activate these profiles with -Phive-x.x.x to build and
test against different Hive versions -->
+ <profile>
+ <id>hive-1.0.0</id>
+ <properties>
+ <hive.version>1.0.0</hive.version>
+
<hivemetastore.hadoop.version>2.6.5</hivemetastore.hadoop.version>
+ <hiverunner.version>3.1.1</hiverunner.version>
+ </properties>
+ </profile>
+ <profile>
+ <id>hive-1.0.1</id>
+ <properties>
+ <hive.version>1.0.1</hive.version>
+
<hivemetastore.hadoop.version>2.6.5</hivemetastore.hadoop.version>
+ <hiverunner.version>3.1.1</hiverunner.version>
+ </properties>
+ </profile>
Review comment:
Let's keep one profile for 1.0.x, as the case for other versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services