lirui-apache commented on a change in pull request #9988: [FLINK-14418][hive] Create HiveModule to provide Hive built-in functions URL: https://github.com/apache/flink/pull/9988#discussion_r341525741
########## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/module/hive/HiveModule.java ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.module.hive; + +import org.apache.flink.table.catalog.hive.client.HiveShim; +import org.apache.flink.table.catalog.hive.client.HiveShimLoader; +import org.apache.flink.table.catalog.hive.factories.HiveFunctionDefinitionFactory; +import org.apache.flink.table.functions.FunctionDefinition; +import org.apache.flink.table.module.Module; + +import org.apache.hadoop.hive.ql.exec.FunctionInfo; + +import java.util.Optional; +import java.util.Set; + +/** + * Module to provide Hive built-in metadata. + */ +public class HiveModule implements Module { + + private final HiveFunctionDefinitionFactory factory; + private final HiveShim hiveShim; + + public HiveModule(String hiveVersion) { + this.hiveShim = HiveShimLoader.loadHiveShim(hiveVersion); + this.factory = new HiveFunctionDefinitionFactory(hiveShim); + } + + @Override + public Set<String> listFunctions() { + return hiveShim.listBuiltInFunctions(); + } + + @Override + public Optional<FunctionDefinition> getFunctionDefinition(String name) { + FunctionInfo info = hiveShim.getBuiltInFunctionInfo(name); + + if (info.isBuiltIn()) { Review comment: The HiveShim API is named `getBuiltInFunctionInfo `. So it doesn't make sense the caller still needs to check whether returned function is built-in or not. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
