azagrebin commented on a change in pull request #10034: [FLINK-14400] Shrink
scope of MemoryManager from TaskExecutor to slot
URL: https://github.com/apache/flink/pull/10034#discussion_r341571657
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -258,15 +253,15 @@ public static TaskManagerServices fromConfiguration(
taskManagerServicesConfiguration.getTaskManagerAddress(),
dataPort);
- // this call has to happen strictly after the network stack has
been initialized
- final MemoryManager memoryManager =
createMemoryManager(taskManagerServicesConfiguration);
-
final BroadcastVariableManager broadcastVariableManager = new
BroadcastVariableManager();
+ // this call has to happen strictly after the network stack has
been initialized
Review comment:
This looks like a stale comment.
Originally, it looks like to be introduced for network pre-allocating direct
memory first (another comment, already deleted). Now memory manager does not
pre-allocate anything anymore, so they should interfere with each other.
Anyways the memory usage should all fit together at the end without overlapping
otherwise it is a bug.
I added a hotfix commit to remove the confusing comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
