bowenli86 commented on a change in pull request #9988: [FLINK-14418][hive]
Create HiveModule to provide Hive built-in functions
URL: https://github.com/apache/flink/pull/9988#discussion_r341686746
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV120.java
##########
@@ -168,4 +174,47 @@ public CatalogColumnStatisticsDataDate
toFlinkDateColStats(ColumnStatisticsData
throw new CatalogException("Failed to create Flink
statistics for date column", e);
}
}
+
+ @Override
+ public Set<String> listBuiltInFunctions() {
+ try {
+ Method method =
FunctionRegistry.class.getMethod("getFunctionNames");
+ // makeSpecFromName is a static method
+ Set<String> names = (Set<String>) method.invoke(null);
+
+ return names.stream()
+ .filter(n -> getFunctionInfo(n).isBuiltIn())
Review comment:
good catch. Seems I didn't rebuilt src but just reran tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
