KurtYoung commented on a change in pull request #9864: [FLINK-14254][table] Introduce FileSystemOutputFormat for batch URL: https://github.com/apache/flink/pull/9864#discussion_r341893621
########## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/filesystem/PartitionWriter.java ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.filesystem; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.io.OutputFormat; +import org.apache.flink.core.fs.Path; + +import java.io.IOException; + +/** + * Partition writer to write records with partition. + * + * <p>See {@link NonPartitionWriter}. + * See {@link DynamicPartitionWriter}. + * See {@link GroupedPartitionWriter}. + * + * @param <T> The type of the consumed records. + */ +@Internal +public interface PartitionWriter<T> { + + /** + * Open writer with {@link Context}. + */ + void open(Context<T> context) throws Exception; + + /** + * Start a transaction. + * In batch mode, there is only one transaction. + * In Streaming mode, every checkpoint should be one transaction. + */ + void startTransaction() throws Exception; + + /** + * Write a record. + */ + void write(T in) throws Exception; + + /** + * End a transaction. + */ + void endTransaction() throws Exception; + + /** + * Context for partition writer, provide some information and generation utils. + */ + interface Context<T> { + + /** + * Prepare output format, configure it and open it. + */ + void prepareOutputFormat(OutputFormat<T> format) throws IOException; + + /** + * Generate a new path without partition. + * + * <p>See {@link NonPartitionWriter}. + */ + Path generatePath() throws Exception; Review comment: Looks like you just put different APIs for different requirements here, like `generatePath()` for `NonPartitionWriter`, and `generatePath(String partition)` for `DynamicPartitionWriter` and `GroupedPartitionWriter`. These interfaces don't looks like to me should be `Context`'s interface, it's just different path strategy for different partition writers. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
