JingsongLi commented on a change in pull request #10068:
[FLINK-13702][FLINK-13740] Fixed issues with generic types and materialization
of lazy binary formats in blink planner
URL: https://github.com/apache/flink/pull/10068#discussion_r341906292
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/BinaryWriter.java
##########
@@ -68,7 +69,7 @@
void writeRow(int pos, BaseRow value, BaseRowSerializer type);
- void writeGeneric(int pos, BinaryGeneric value);
+ void writeGeneric(int pos, BinaryGeneric value, BinaryGenericSerializer
innerSerializer);
Review comment:
Or just use real inner serializer instead of `BinaryGenericSerializer`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
