AT-Fieldless opened a new pull request #10074: [FLINK-14499][Runtime / Metrics]MetricRegistry#getMetricQueryServiceGatewayRpcAddress is Nonnull URL: https://github.com/apache/flink/pull/10074 ## What is the purpose of the change refactor MetricRegistry#getMetricQueryServiceGatewayRpcAddress's related code, because it is now non-null ## Brief change log In production code, replace @Nullable with @NonNull and add checkNonNull code. In testing code, start a dummy MetricQueryService for tests. ## Verifying this change This change is already covered by existing tests, such as *(please describe tests)*. - DispatcherResourceCleanupTest - TaskExecutorPartitionLifecycleTest - TaskExecutorTest - TaskSubmissionTestEnvironment - TestingTaskExecutor ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (don't know) - The runtime per-record code paths (performance sensitive): (don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (don't know) - The S3 file system connector: (don't know) ## Documentation - Does this pull request introduce a new feature? (no)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
