wuchong commented on a change in pull request #10039: [FLINK-14262][table]
Support referencing function with fully/partially qualified names in SQL
URL: https://github.com/apache/flink/pull/10039#discussion_r342375742
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/catalog/CatalogTableITCase.scala
##########
@@ -84,6 +94,41 @@ class CatalogTableITCase(isStreamingMode: Boolean) {
tableEnv.execute(name)
}
+ private def testUdf(sql: String): Unit = {
+ val sinkDDL =
+ """
+ |create table sinkT(
+ | a bigint
+ |) with (
+ | 'connector' = 'COLLECTION'
+ |)
+ """.stripMargin
+ tableEnv.sqlUpdate(sinkDDL)
+ tableEnv.sqlUpdate(sql)
+ tableEnv.execute("")
+ assertEquals(Seq(toRow(2L)), TestCollectionTableFactory.RESULT.sorted)
Review comment:
The expected result is hard code here which is not clean. It would be better
to pass in the expected result as parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
