hequn8128 commented on a change in pull request #10017: [FLINK-14019][python]
add support for managing environment and dependencies of Python UDF in Flink
Python API
URL: https://github.com/apache/flink/pull/10017#discussion_r342049265
##########
File path:
flink-python/src/main/java/org/apache/flink/streaming/api/operators/python/AbstractPythonFunctionOperator.java
##########
@@ -75,6 +80,7 @@
* A timer that finishes the current bundle after a fixed amount of
time.
*/
private transient ScheduledFuture<?> checkFinishBundleTimer;
+ protected PythonEnvironmentManager environmentManager;
Review comment:
I see `environmentManager` has already declared in
`AbstractPythonFunctionRunner`, so maybe it's unnecessary to also add it here.
The related initialization can also be moved into
`AbstractPythonFunctionRunner`.
On the other hand, the environment is created in Runner currently, so put
environmentManager in Runner is also consistent with it.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
