AHeise commented on a change in pull request #10029: [FLINK-14553][runtime] Respect non-blocking output in StreamTask#processInput URL: https://github.com/apache/flink/pull/10029#discussion_r342419688
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/MultipleRecordWriters.java ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.api.writer; + +import org.apache.flink.core.io.IOReadableWritable; +import org.apache.flink.runtime.event.AbstractEvent; +import org.apache.flink.util.ExceptionUtils; + +import java.io.IOException; +import java.util.List; +import java.util.concurrent.CompletableFuture; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * The specific delegate implementation for the multiple outputs case. + */ +public class MultipleRecordWriters<T extends IOReadableWritable> implements RecordWriterDelegate<T> { + + private final List<RecordWriter<T>> recordWriters; + private final CompletableFuture<?>[] futures; Review comment: Is that field only to avoid object allocation in `#getAvailabilityFuture`? If so, can you add a comment on this field. Purely optional: I like to tag those fields transient even if the class is not serializable, just to show that this field is actually a cache. Check if that makes sense to you or ignore this comment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
