[ 
https://issues.apache.org/jira/browse/FLINK-14059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967362#comment-16967362
 ] 

Dawid Wysakowicz commented on FLINK-14059:
------------------------------------------

Hi all,
Sorry for jumping in so late and also not participating in the discussion 
earlier. 

I would like to ask though if it is really necessary to have this setting in a 
user facing {{Public}} API? As far as I can tell this is an internal setting 
that users should not be bothered with. Can't we set it e.g. on the 
{{StreamGraph}} directly? I think we are mixing a few responsibilities in the 
{{ExecutionConfig}} class (both user facing configuration and internal 
configuration). We have a similar issue with options such as: 
{{defaultInputDependencyConstraint}} and {{executionMode}}. I think we should 
not pollute the {{ExecutionConfig}} with internal options if possible.

> Introduce option allVerticesInSameSlotSharingGroupByDefault in ExecutionConfig
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-14059
>                 URL: https://issues.apache.org/jira/browse/FLINK-14059
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Coordination, Table SQL / Runtime
>    Affects Versions: 1.10.0
>            Reporter: Xintong Song
>            Assignee: Zhu Zhu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.10.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> * Introduce option -{{allSourcesInSamePipelinedRegion}}- 
> {{allVerticesInSameSlotSharingGroupByDefault}} in {{ExecutionConfig}}
>  * Set it to {{true}} by default
>  * Set it to {{false}} for SQL/Table API bounded batch jobs by the Blink 
> planner
> This step should not introduce any behavior changes. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to