tillrohrmann commented on a change in pull request #10007:
[FLINK-14060][runtime] Set slot sharing groups according to logical pipelined
regions
URL: https://github.com/apache/flink/pull/10007#discussion_r342481078
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
##########
@@ -654,4 +656,86 @@ public void
testNotSupportInputSelectableOperatorIfCheckpointing() {
StreamingJobGraphGenerator.createJobGraph(env.getStreamGraph());
}
+
+ @Test
+ public void
testSlotSharingOnAllVerticesInSameSlotSharingGroupByDefaultEnabled() {
+ final StreamGraph streamGraph =
createStreamGraphForSlotSharingTest();
+ // specify slot sharing group for map1
+ streamGraph.getStreamNodes().stream()
+ .filter(n -> "map1".equals(n.getOperatorName()))
+ .findFirst()
+ .get()
+ .setSlotSharingGroup("testSlotSharingGroup");
+
streamGraph.getExecutionConfig().enableAllVerticesInSameSlotSharingGroupByDefault();
Review comment:
Not sure about this tbh. I think in the future I would propose to take a
conservative approach here and to not expose things to the user unless really
needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
