xuefuz commented on a change in pull request #10092: [FLINK-14580][hive] add HiveModuleFactory, HiveModuleDescriptor, and HiveModuleDescriptorValidator URL: https://github.com/apache/flink/pull/10092#discussion_r342873183
########## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/module/hive/HiveModuleDescriptorValidator.java ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.module.hive; + +import org.apache.flink.table.descriptors.DescriptorProperties; +import org.apache.flink.table.descriptors.ModuleDescriptorValidator; + +/** + * Validator for {@link HiveModuleDescriptor}. + */ +public class HiveModuleDescriptorValidator extends ModuleDescriptorValidator { + public static final String MODULE_TYPE_HIVE = "hive"; + public static final String MODULE_HIVE_VERSION = "hive-version"; + + @Override + public void validate(DescriptorProperties properties) { + super.validate(properties); + properties.validateValue(MODULE_TYPE, MODULE_TYPE_HIVE, false); + properties.validateString(MODULE_HIVE_VERSION, true, 1); Review comment: should we verify that one of the hive versions that we have shims for? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
