danny0405 commented on a change in pull request #10096:
[FLINK-14623][table-api] Add computed column information into TableSc…
URL: https://github.com/apache/flink/pull/10096#discussion_r343001982
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/descriptors/DescriptorProperties.java
##########
@@ -257,6 +267,43 @@ public void putIndexedFixedProperties(String key,
List<String> subKeys, List<Lis
}
}
+ /**
+ * Adds an indexed sequence of properties (with sub-properties) under a
common key.
+ * Different with {@link #putIndexedFixedProperties}, this method
supports the properties
+ * value to be null, which would be ignore. The sub-properties should
at least have
+ * one non-null value.
+ *
+ * <p>For example:
+ *
+ * <pre>
+ * schema.fields.0.type = INT, schema.fields.0.name = test
+ * schema.fields.1.type = LONG, schema.fields.1.name = test2
+ * schema.fields.2.type = LONG, schema.fields.1.expr = test + 1
+ * </pre>
+ *
+ * <p>The arity of each subKeyValues must match the arity of
propertyKeys.
+ */
+ public void putIndexedOptionalProperties(String key, List<String>
subKeys, List<List<String>> subKeyValues) {
Review comment:
I prefer not, `putIndexedFixedProperties` has more strict check logic, and
it can be used not only for table fields and names, we better keep it i think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
