GJL commented on a change in pull request #10082: [FLINK-14164][runtime] Add a
meter ‘numberOfRestarts’ to show number of restarts as well as its rate
URL: https://github.com/apache/flink/pull/10082#discussion_r343082666
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java
##########
@@ -140,6 +143,7 @@
private final Time slotRequestTimeout;
+ private final Counter numberOfRestartsCounter;
Review comment:
What is the benefit of using a `Counter` over a `Gauge`? We never decrement
the number of restarts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
