wuchong commented on a change in pull request #10096: [FLINK-14623][table-api]
Add computed column information into TableSc…
URL: https://github.com/apache/flink/pull/10096#discussion_r343138995
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/descriptors/DescriptorProperties.java
##########
@@ -76,6 +77,8 @@
public static final String TABLE_SCHEMA_TYPE = "type";
+ public static final String TABLE_SCHEMA_EXPR = "expr";
Review comment:
From my point of view, `TABLE_SCHEMA_EXPR` is better than
`TABLE_SCHEMA_COMPUTED_COLUMNS`. Because "computed column" contains name and
expression and maybe type.
Maybe `TABLE_SCHEMA_COLUMN_EXPR` is a better choice, but this needs to
change `TABLE_SCHEMA_TYPE` and `TABLE_SCHEMA_NAME` too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
