KurtYoung commented on a change in pull request #10096:
[FLINK-14623][table-api] Add computed column information into TableSc…
URL: https://github.com/apache/flink/pull/10096#discussion_r343418958
##########
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
##########
@@ -237,6 +239,36 @@ public String getColumnSqlString() {
return writer.toString();
}
+ /**
+ * Split the computed columns expression into string key-value pairs.
+ *
+ * <p>For example, {@code col2 as to_timestamp(col1)} would be split
into pair:
+ * (col2, to_timestamp(col1)).
+ *
+ * @return computed column name to expression mapping
+ **/
+ public Map<String, String> getComputedColumnMap() {
Review comment:
I would prefer to add it in your following PR. There is no "context" for
reviewers to assess whether this method is reasonable to add.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
