KurtYoung commented on a change in pull request #10098:
[FLINK-14326][FLINK-14324][table] Support to apply watermark assigner in planner
URL: https://github.com/apache/flink/pull/10098#discussion_r343461587
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/sources/TableSourceUtil.scala
##########
@@ -139,13 +138,15 @@ object TableSourceUtil {
*
* @param tableSource The [[TableSource]] for which the Calcite schema is
generated.
* @param selectedFields The indices of all selected fields. None, if all
fields are selected.
+ * @param watermarkSpec The watermark information (passed in from DDL)
* @param streaming Flag to determine whether the schema of a stream or
batch table is created.
* @param typeFactory The type factory to create the schema.
* @return The Calcite schema for the selected fields of the given
[[TableSource]].
*/
def getRelDataType(
tableSource: TableSource[_],
selectedFields: Option[Array[Int]],
+ watermarkSpec: Option[WatermarkSpec],
Review comment:
don't think this should be taken care by **TableSource**Util. TableSource
only responsible for reading data out of underlying storage, watermark is
generated after that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
