JingsongLi commented on issue #9433: [FLINK-13708] [table-planner-blink] 
transformations should be cleared after execution in blink planner
URL: https://github.com/apache/flink/pull/9433#issuecomment-550970032
 
 
   > when/what/why is buffered? I will list from my understanding:
   > 
   > 1. operations should be buffered in unified table env. In order to reuse 
the shared part in the graph. And should be cleared after `execute` is invoked. 
(This is what we do currently.)
   > 2. transformations should be buffered in `Executor` not in 
`StreamExecutionEnvironment` in blink planner. Blink batch need to set 
additional properties on the transformation before execute. We should also 
clear the buffered transformations after `execute` is invoked.
   
   Hi @wuchong @godfreyhe , I agree with @dawidwys , we should let `Executor` 
stateless (Except its field `StreamExecutionEnvironment`). 
   Why we need buffer `transformations`? Just add them to 
`StreamExecutionEnvironment`?
   You can take a look to `StreamExecutionEnvironment.execute(StreamGraph)`, 
this will clear `transformations` in `StreamExecutionEnvironment`. I think this 
can solve your concerns?
   So I think we don't have reason to buffer transformations? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to