pnowojski commented on a change in pull request #9885:
[FLINK-14344][checkpointing] A preparation for snapshotting master hook state
asynchronously
URL: https://github.com/apache/flink/pull/9885#discussion_r343530956
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -659,12 +658,14 @@ else if (!props.forceCheckpoint()) {
cancellerHandle.cancel(false);
}
- // trigger the master hooks for the checkpoint
- final Map<String, MasterState> masterStates =
MasterHooks.triggerMasterHooks(masterHooks.values(),
- checkpointID, timestamp,
executor, Time.milliseconds(checkpointTimeout));
- for (Map.Entry<String, MasterState> entry :
masterStates.entrySet()) {
-
checkpoint.acknowledgeMasterState(entry.getKey(), entry.getValue());
+ // TODO, asynchronously snapshots master hook
without waiting here
Review comment:
Please also elaborate in the commit message of `[FLINK-14344][checkpointing]
MasterHooks supports asynchronously snapshotting state`. For example:
```
[FLINK-14344][checkpointing] MasterHooks class supports asynchronous
triggering
This commits add supports for asynchronous triggering `MasterHooks`.
As for now, they are still being fired synchronously by the
`CheckpointCoordinator`.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
