dawidwys commented on a change in pull request #10039: [FLINK-14262][table]
Support referencing function with fully/partially qualified names in SQL
URL: https://github.com/apache/flink/pull/10039#discussion_r343542386
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/catalog/FunctionCatalogOperatorTable.java
##########
@@ -84,12 +89,12 @@ public void lookupOperatorOverloads(
return;
}
- String name = opName.getSimple();
- Optional<FunctionLookup.Result> candidateFunction =
functionCatalog.lookupFunction(
- FunctionIdentifier.of(name));
+ FunctionIdentifier identifier =
toFunctionIdentifier(opName.names.toArray(new String[0]), catalogManager);
Review comment:
How about we use the UnresolvedIdentifier here? I think we could adjust the
`FunctionCatalog#lookupFunction` slightly and make it accept the
`UnresolvedIdentifier`. Than this qualifying could happen within
`FunctionCatalog`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
